Add module info via moditect #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am opening two PRs. Currently, i'm working through the transitive dependencies of Spring to get closer to all of spring being able to be used with jlink.
This is one of those transitive deps.
On this branch I added a module-info via moditect. This would keep the annotations compiled at bytecode level 5. On the other PR I will do the same, but just bump the java version up to the minimum required for a module-info.
As its kinda hard to get a JVM that can compile java 5 code, this solution was hard for me to verify.
https://spring-modularization.netlify.app/
